Add light theme to Qdarkstyle #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use prefix in qrc according to palette identifier
Also fix a small error with it
|
I rebased this with develop in order to include the last merged changes. I think this one is ready for review @dpizetta |
|
@dpizetta, I merged again with develop to fix the merge conflicts with your latest changes. |
Closed
|
Hi Daniel! I'm posting here a screenshot of the light theme in Spyder and things are working fine! (The cantered tabs in editor and console will be fixed in Spyder but they are not related to QDarkstyle).
|
|
@juanis2112 tks, it is already released :) Please check the buttons I mentioned in #260. Tks for your collaboration! |
|
Thanks a lot for your help @dpizetta! It's been great collaborating with you on getting this release done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds everything needed for having a light theme in QDarkstyle