Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expectation of warning for uproot3 #444

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

lgray
Copy link
Collaborator

@lgray lgray commented Feb 5, 2021

No description provided.

@nsmith-
Copy link
Member

nsmith- commented Feb 5, 2021

This seems to have been a change in uproot3 3.14.3 from 3.14.2, and I was hoping the warning would be re-introduced. @jpivarski is this expected that we no longer see a warning?

    def test_export1d():
        with pytest.warns(FutureWarning):
>           import uproot3
E           Failed: DID NOT WARN. No warnings of type (<class 'FutureWarning'>,) was emitted. The list of emitted warnings is: [].
tests/test_hist_tools.py:164: Failed

@lgray lgray merged commit 921e982 into master Feb 5, 2021
@nsmith-
Copy link
Member

nsmith- commented Feb 5, 2021

Answered in scikit-hep/uproot3#533

@lgray lgray deleted the uproot3-checkwarn-remove branch November 17, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants