Fix regenerating site for change in excluded files while tasting #265
Conversation
…file excluded in the configuration.
|
It was a bit too early to submit this PR. The first attempt for the fix was not correct :( |
- Use SiteContextGenerator.IsExcludedPath() for exclude detection instead of CanBeIncluded() - for this the method visibility had to be changed to public.
| { | ||
| return excludes.Contains(relativePath) || excludes.Any(e => relativePath.StartsWith(e)); | ||
| } | ||
|
|
||
| private bool IsIncludedPath(string relativePath) | ||
| public bool IsIncludedPath(string relativePath) |
There was a problem hiding this comment.
True, I only changed visibility to be "semantically symmetric" with IsExcludedPath. Should I add unit test for this as well, ot revert this change?
There was a problem hiding this comment.
You have a point about the "semantically symmatric", leave the change and just add some unit tests please.
|
Thanks for your PR! |
|
I was just about to create a similar pull request when I stumbled over this one 😄 |
|
Hi! offtopic note: the github "reply to this email to comment" feature did not quite work as intended. :( |
|
I hope these tests are enough. I don't think these methods need anything more complicated. |
…file-changes Fix regenerating site for change in excluded files while tasting
|
Thanks! 😃 |
|
👍 Thanks |
Taste mode does not trigger complete regeneration of the change of a file excluded in the configuration.
Fixes #264