This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Refactor logging #260
Merged
Refactor logging #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some type safety instead of magic strings, and flush after receiving error message to prevent log data loss on crashing on uncaught exceptions
|
Overall using a proper logging library, like Serilog, with ConsoleLogger output would be a better choice, IMHO. |
|
Thanks for your PR, that was needed 😃 You are right about the use of a proper logging library, can you create an issue about that so we can start to debate about the library to use? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on crashing on uncaught exceptions