Don't override defines in case they're already set at project level #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #define LOG_LEVEL 2 | ||
| #ifndef DD_NSLOG_LEVEL | ||
| #define DD_NSLOG_LEVEL 2 | ||
| #endif |
There was a problem hiding this comment.
I would prefer a:
#ifndef LOG_LEVEL
#define LOG_LEVEL 2
#endifinstead.
There was a problem hiding this comment.
LOG_LEVEL is very generic and it could be confused with the actual Cocoalumberjack log level. Here this define is specifically only used for NSLogs which is why I suggested renaming it to be clearer.
There was a problem hiding this comment.
Well, this is internal to a .m file so we can use whatever we want, right.
There was a problem hiding this comment.
Well, the whole point of not redefining it if it's already defined is that it could be defined earlier, like let's say in Xcode build settings for a specific configuration (DEBUG). In this case, the naming is important to not be confusing.
rivera-ernesto
added a commit
that referenced
this pull request
Jul 9, 2015
Don't override defines in case they're already set at project level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.