fence_openstack: added --auth-plugin option to allow usage of app credentials instead of user credentials #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of application credentials in clouds.yml instead of user credentials
|
Can one of the admins verify this patch? |
oalbrigt
changed the title
oalbrigt
requested changes
Mar 17, 2023
| @@ -1,4 +1,4 @@ | |||
| #!@PYTHON@ -tt | |||
| #!/usr/libexec/platform-python -tt | |||
There was a problem hiding this comment.
Dont change these, as they're replaced to the path found by ./configure during make.
| @@ -251,6 +258,15 @@ def define_new_opts(): | |||
| "default": 60, | |||
| "order": 10, | |||
| } | |||
| all_opt["auth_plugin"] = { | |||
There was a problem hiding this comment.
Use - instead of _ to stay consistent with the rest of the agent.
|
You'll also have to run |
|
ok thx for your time. I'm gonna fix the issues you pointed out and get back here :) |
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-533/1/input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to user Barbican to generate app creds and put them in the clouds.yml:
The app creds can have smaller perm from user and they can be easly generated by users instead of full cloud accounts
To user this feature user can run:
$ fence_openstack --cloud openstack -n INSTANCEUUID -o list --auth_plugin v3applicationcredential