Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: corosync: fix linknumber validation (#1546) #1549

Conversation

nicholasyang2022
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.18%. Comparing base (af15166) to head (aec7ae9).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/ui_corosync.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 55.19% <75.00%> (ø)
unit 52.72% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/corosync.py 87.64% <100.00%> (ø)
crmsh/ui_corosync.py 76.79% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review September 9, 2024 05:14
@liangxin1300 liangxin1300 merged commit 1d497d0 into ClusterLabs:master Sep 9, 2024
32 checks passed
@nicholasyang2022 nicholasyang2022 deleted the fix-1546-linknumber-validation branch September 9, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants