Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Dev: bootstrap: implement ssh-agent support (jsc#PED-5774) #1261

Merged
merged 14 commits into from
Nov 23, 2023

Fix: bootstrap: add informative logging for generating new ssh keypairs

6a49af9
Select commit
Loading
Failed to load commit list.
Merged

[crmsh-4.6] Dev: bootstrap: implement ssh-agent support (jsc#PED-5774) #1261

Fix: bootstrap: add informative logging for generating new ssh keypairs
6a49af9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 23, 2023 in 0s

53.06% (+0.53%) compared to 373ddb9

View this Pull Request on Codecov

53.06% (+0.53%) compared to 373ddb9

Details

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (373ddb9) 52.52% compared to head (6a49af9) 53.06%.

Files Patch % Lines
crmsh/bootstrap.py 78.99% 46 Missing ⚠️
crmsh/ssh_key.py 68.90% 37 Missing ⚠️
crmsh/sh.py 83.60% 10 Missing ⚠️
crmsh/report/collect.py 25.00% 3 Missing ⚠️
crmsh/report/utillib.py 0.00% 1 Missing ⚠️
crmsh/ui_cluster.py 83.33% 1 Missing ⚠️
crmsh/utils.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           crmsh-4.6    #1261      +/-   ##
=============================================
+ Coverage      52.52%   53.06%   +0.53%     
=============================================
  Files             83       83              
  Lines          25354    25617     +263     
=============================================
+ Hits           13317    13593     +276     
+ Misses         12037    12024      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.