Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: qdevice: Unable to setup qdevice under non-root user (bsc#1208770) #1135

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Fix: qdevice: Unable to setup qdevice under non-root user (bsc#1208770) #1135

merged 2 commits into from
Mar 2, 2023

Conversation

nicholasyang2022
Copy link
Collaborator

  • When --qnetd-hostname is provided as "user@host", use the specified user
  • When --qnetd-hostname is provided as "host", use the same username as the local user

@nicholasyang2022 nicholasyang2022 force-pushed the qnetd_non_root_20230227 branch 2 times, most recently from 8379bc0 to f38cfaf Compare February 28, 2023 06:16
@liangxin1300
Copy link
Collaborator

liangxin1300 commented Feb 28, 2023 •
edited
Loading 

INFO: Configure Qdevice/Qnetd:
INFO: Copy ssh key to qnetd node(root@qnetd-node)
INFO: Configuring SSH passwordless with root@qnetd-node

Above two lines are duplicated, keep one

root@qnetd-node's password: 
Check whether corosync-qnetd is installed on qnetd-node

Above one line could be suppressed

liangxin1300
liangxin1300 reviewed Mar 1, 2023
View reviewed changes
crmsh/utils.py
@@ -3457,4 +3462,43 @@ def check_user_access(level_name):
else:
logger.error("Please run this command starting with \"sudo\"")
raise TerminateSubCommand


class HostUserConfig:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments for this class

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A docstring is added.

@nicholasyang2022 nicholasyang2022 changed the title Dev: qdevice: support configuring qnetd with non-root sudoer (jsc#PED-290) Fix: qdevice: Unable to setup qdevice under non-root user (bsc#1208770) Mar 1, 2023
@nicholasyang2022
Fix: qdevice: Unable to setup qdevice under non-root user (bsc#1208770)
f56e398 
* When --qnetd-hostname is provided as "user@host", use the specified user
* When --qnetd-hostname is provided as "host", use the same username as the local user
@nicholasyang2022
Dev: unittest: Adjust unit test for previous changes
136d339
@liangxin1300 liangxin1300 merged commit 2ed0ab1 into ClusterLabs:master Mar 2, 2023
@nicholasyang2022 nicholasyang2022 deleted the qnetd_non_root_20230227 branch March 6, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxin1300 liangxin1300 liangxin1300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasyang2022 @liangxin1300