add ID to Mount / Unmount for docker 1.12

[wallnerryan]

Because docker added IDs to Mount() / Unmount()

Right now we choose to do nothing with the ID but add it to our plugin layer so that calls will continue to work with docker 1.12

https://clusterhq.atlassian.net/browse/FLOC-4480
#2854

[wallrj]

I've got a feeling that this is going to break with Docker < 1.12.0 which won't supply an ID.
If I'm right, then we should give it a default value and add a test that the API can can be called with and without the ID.

[wallnerryan]

good point. (Another reason our tests should include other docker versions)

[wallnerryan]

will verify it breaks with < 1.12, then make changes.

[wallnerryan]

confirmed this does break.

WARN[1065] 716e7f439070882877e3f401d06edc76b6c2d59cd48fb819b8fa3d80394afa02 cleanup: Failed to umount volumes: TypeError: volumedriver_unmount() takes exactly 3 arguments (2 given)
ERRO[1065] Handler for POST /v1.22/containers/716e7f439070882877e3f401d06edc76b6c2d59cd48fb819b8fa3d80394afa02/start returned error: TypeError: volumedriver_mount() takes exactly 3 arguments (2 given)
docker: Error response from daemon: TypeError: volumedriver_mount() takes exactly 3 arguments (2 given).
root@mha-aws-demo0:/home/ubuntu# docker version
Client:
 Version:      1.10.0
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   590d5108
 Built:        Thu Feb  4 19:55:25 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.0
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   590d5108
 Built:        Thu Feb  4 19:55:25 2016
 OS/Arch:      linux/amd64

[wallrj]

Thanks @wallnerryan

Please address or answer the comments above and merge when all the tests have passed.

Probably worth forcing the acceptance tests too....the non-loopback ones listed under the "cron"

[wallnerryan]

@wallrj how come the acceptance tests under cron dont kick off automatically ?

[wallrj]

how come the acceptance tests under cron dont kick off automatically ?

Because they're so slow.

We made a decision that it was sufficient to see the loopback acceptance tests pass .
The loopback accceptance tests use the loopback backend and therefore don't include any of the multi-node, dataset moving tests.
The full acceptance tests are run nightly on master.
And the idea is that we check the build results on master and notice any new errors.

[wallnerryan]

part of combined branch #2880