Add axis to apply_ragged and unpack_ragged
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, reduced xr.DataArrays, and multi-variable results
philippemiron
approved these changes
Sep 22, 2023
selipot
requested changes
Sep 25, 2023
|
@selipot Please check the docstring and merge when ready. |
selipot
approved these changes
Sep 26, 2023
philippemiron
pushed a commit
to philippemiron/clouddrift
that referenced
this pull request
Nov 16, 2023
* coriolis_frequency is not expected to warn * Use np.split in unpack_ragged * Add axis to apply_ragged and unpack_ragged * Reorder tests * Bump minor version * Make apply_ragged work for various edge cases with reduction functions, reduced xr.DataArrays, and multi-variable results * Expand and update the docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
axistoapply_raggedandunpack_raggedto specify unpacking/concatenation axis; default is 0, which is consistent withnp.concatenateandnp.split.xr.DataArrays now works.coriolis_frequencythat tested for a Warning that shouldn't be there. I don't know why tests were passing onmainbut this was failing for me. It's fixed.Closes #274.