Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly require core_ext for String#strip_heredoc #350

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Directly require core_ext for String#strip_heredoc #350

merged 3 commits into from
Sep 13, 2019

Conversation

tommy-gilligan
Copy link
Contributor

This is needed for Rails 6+ as this core_ext is no longer indirectly loaded.
It would be nice to use

<<~HEREDOC
    this will lose indentation
HEREDOC

introduced in Ruby 2.3 but this would break backwards compatibility.

Tom Gilligan and others added 3 commits August 13, 2019 22:09
@seuros seuros merged commit 586b67d into ClosureTree:master Sep 13, 2019
manxingxing pushed a commit to otof-yangyu/closure_tree that referenced this pull request Oct 12, 2019
@manxingxing
Directly require core_ext for String#strip_heredoc (ClosureTree#350)
ed0bf96
lizdeika pushed a commit to lizdeika/closure_tree that referenced this pull request Dec 3, 2019
@lizdeika
Directly require core_ext for String#strip_heredoc (ClosureTree#350)
4618afc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommy-gilligan @seuros