Added documentation for has_closure_tree_root #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please re-open when all tests pass. |
|
Hello there. This is still in my todo list. Sorry I haven't done it yet... |
|
I just poked at the Travis failure and saw it was a network error. The failures happened right at a version boundary, so I had misinterpreted them as exposing a version incompatible PR, which is why I incorrectly closed it back in Dec. I've restarted the build here. In any event, this diff looks great. @hooverlunch thanks for your work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try this on for size. I also added some generic notes about eager loading since the topic is not currently mentioned in the docs.