-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wind turbine map special #51516
Merged
Rivet-the-Zombie
merged 5 commits into
CleverRaven:master
from
wapcaplet:w-wind-turbine
Sep 12, 2021
Merged
Add wind turbine map special #51516
Rivet-the-Zombie
merged 5 commits into
CleverRaven:master
from
wapcaplet:w-wind-turbine
Sep 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Enhancement / Feature>
New features, or enhancements on existing
[JSON]
Changes (can be) made in JSON
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
labels
Sep 11, 2021
actual-nh
reviewed
Sep 11, 2021
actual-nh
reviewed
Sep 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These may need some JSON formatting.
Thanks @actual-nh for all the suggestions. This is getting to be in pretty good shape. I will clean things up with a rebase and push a second draft with screenshots shortly. |
wapcaplet
force-pushed
the
w-wind-turbine
branch
from
September 11, 2021 17:20
3604085
to
a3a1e45
Compare
Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>
wapcaplet
force-pushed
the
w-wind-turbine
branch
from
September 11, 2021 17:29
a3a1e45
to
905c625
Compare
actual-nh
reviewed
Sep 11, 2021
actual-nh
approved these changes
Sep 12, 2021
Zlorthishen
added a commit
to Zlorthishen/Cataclysm-BN
that referenced
this pull request
Apr 6, 2024
https: //github.com/CleverRaven/Cataclysm-DDA/pull/51516 https: //github.com/CleverRaven/Cataclysm-DDA/pull/51476 https: //github.com/CleverRaven/Cataclysm-DDA/pull/63534 Co-Authored-By: John Bytheway <52664+jbytheway@users.noreply.github.com> Co-Authored-By: Eric Pierce <238395+wapcaplet@users.noreply.github.com>
scarf005
pushed a commit
to cataclysmbnteam/Cataclysm-BN
that referenced
this pull request
Apr 13, 2024
* initial commit https: //github.com/CleverRaven/Cataclysm-DDA/pull/51516 https: //github.com/CleverRaven/Cataclysm-DDA/pull/51476 https: //github.com/CleverRaven/Cataclysm-DDA/pull/63534 Co-Authored-By: John Bytheway <52664+jbytheway@users.noreply.github.com> Co-Authored-By: Eric Pierce <238395+wapcaplet@users.noreply.github.com> * style(autofix.ci): automated formatting * Update wind_turbine.json * Update wind_turbine.json * Update wind_turbine.json * style(autofix.ci): automated formatting * Update furniture-industrial.json adding electrical grid support * Update deconstruction.json add in a way to deconstruct new furniture * style(autofix.ci): automated formatting * Update overmap_terrain.json because i am cruel * style(autofix.ci): automated formatting * Update specials.json * Update data/json/overmap/overmap_special/specials.json Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com> --------- Co-authored-by: John Bytheway <52664+jbytheway@users.noreply.github.com> Co-authored-by: Eric Pierce <238395+wapcaplet@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
<Enhancement / Feature>
New features, or enhancements on existing
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Add wind turbine map special"
Purpose of change
Wind turbines are becoming ubiquitous in the US, but none yet existed in the game.
Describe the solution
Add
data/json/mapgen/wind_turbine.json
defining the structure shape. It only includes the tower and nacelle, and a suggestion of the rotor cowl.Add to
specials.json
the "Wind Turbine" special with 9 levels of tower. (smaller wind turbines could simply use fewer pillar levels).Add to
overmap_terrain.json
the map symbol and color for the turbine's levels.Add two new furnitures and include them in the turbine structure:
f_electrical_conduit
, a shielded bundle of electrical wiring that runs from the base to the top, andf_wind_vane
, a basic weather vane that swivels with wind direction, added to the roof of the nacelle along with a cell signal booster.Describe alternatives you've considered
These were part of my wishlist when I started this PR, now I am fairly satisfied with the solutions:
A future PR should add a wind farm with several turbines, and some kind of power substation.
Testing
Debug-spawn a wind turbine, teleport inside (door locked), climb to the top and look around.
Ground floor, with switchgear (breakers and fuses) and ladder:
Middle, no platform:
Middle, with platform:
Inside of nacelle:
Roof (you can't walk on the rotor cowl, it's too slippery):
Stepping off the edge is an effective QYY alternative.
Additional context
Wind power is not exceptionally popular in the New England area, but a few wind farms do exist there - this site has a nice interactive map: https://eerscmap.usgs.gov/uswtdb/