Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wind turbine map special #51516

Merged
merged 5 commits into from
Sep 12, 2021

Conversation

wapcaplet
Copy link
Contributor

@wapcaplet wapcaplet commented Sep 11, 2021

Summary

Content "Add wind turbine map special"

Purpose of change

Wind turbines are becoming ubiquitous in the US, but none yet existed in the game.

Describe the solution

Add data/json/mapgen/wind_turbine.json defining the structure shape. It only includes the tower and nacelle, and a suggestion of the rotor cowl.

Add to specials.json the "Wind Turbine" special with 9 levels of tower. (smaller wind turbines could simply use fewer pillar levels).

Add to overmap_terrain.json the map symbol and color for the turbine's levels.

Add two new furnitures and include them in the turbine structure: f_electrical_conduit, a shielded bundle of electrical wiring that runs from the base to the top, and f_wind_vane, a basic weather vane that swivels with wind direction, added to the roof of the nacelle along with a cell signal booster.

Describe alternatives you've considered

These were part of my wishlist when I started this PR, now I am fairly satisfied with the solutions:

  • The roof should include some weather instruments, a wind vane at least (though none appears to exist in-game yet).
  • The interior of the pillar should include some kind of high-voltage wiring harness.
  • The nacelle should ideally have some kind of recognizable and logical arrangement of mechanisms - for now it's filled with broken generators. I skimmed a couple YouTube videos touring them, and there's a lot more going on in there.

A future PR should add a wind farm with several turbines, and some kind of power substation.

Testing

Debug-spawn a wind turbine, teleport inside (door locked), climb to the top and look around.

Ground floor, with switchgear (breakers and fuses) and ladder:

image

Middle, no platform:

image

Middle, with platform:

image

Inside of nacelle:

image

Roof (you can't walk on the rotor cowl, it's too slippery):

image

Stepping off the edge is an effective QYY alternative.

Additional context

Wind power is not exceptionally popular in the New England area, but a few wind farms do exist there - this site has a nice interactive map: https://eerscmap.usgs.gov/uswtdb/

@actual-nh actual-nh added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Sep 11, 2021
Copy link
Contributor

@actual-nh actual-nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These may need some JSON formatting.

data/json/mapgen/wind_turbine.json Outdated Show resolved Hide resolved
data/json/mapgen/wind_turbine.json Outdated Show resolved Hide resolved
data/json/mapgen/wind_turbine.json Outdated Show resolved Hide resolved
data/json/mapgen/wind_turbine.json Outdated Show resolved Hide resolved
data/json/mapgen/wind_turbine.json Outdated Show resolved Hide resolved
@wapcaplet
Copy link
Contributor Author

Thanks @actual-nh for all the suggestions. This is getting to be in pretty good shape. I will clean things up with a rebase and push a second draft with screenshots shortly.

Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>
@wapcaplet wapcaplet marked this pull request as ready for review September 12, 2021 03:54
@Rivet-the-Zombie Rivet-the-Zombie merged commit 76bac85 into CleverRaven:master Sep 12, 2021
Zlorthishen added a commit to Zlorthishen/Cataclysm-BN that referenced this pull request Apr 6, 2024
https: //github.com/CleverRaven/Cataclysm-DDA/pull/51516
https: //github.com/CleverRaven/Cataclysm-DDA/pull/51476
https: //github.com/CleverRaven/Cataclysm-DDA/pull/63534
Co-Authored-By: John Bytheway <52664+jbytheway@users.noreply.github.com>
Co-Authored-By: Eric Pierce <238395+wapcaplet@users.noreply.github.com>
scarf005 pushed a commit to cataclysmbnteam/Cataclysm-BN that referenced this pull request Apr 13, 2024
* initial commit

https: //github.com/CleverRaven/Cataclysm-DDA/pull/51516
https: //github.com/CleverRaven/Cataclysm-DDA/pull/51476
https: //github.com/CleverRaven/Cataclysm-DDA/pull/63534
Co-Authored-By: John Bytheway <52664+jbytheway@users.noreply.github.com>
Co-Authored-By: Eric Pierce <238395+wapcaplet@users.noreply.github.com>

* style(autofix.ci): automated formatting

* Update wind_turbine.json

* Update wind_turbine.json

* Update wind_turbine.json

* style(autofix.ci): automated formatting

* Update furniture-industrial.json

adding electrical grid support

* Update deconstruction.json

add in a way to deconstruct new furniture

* style(autofix.ci): automated formatting

* Update overmap_terrain.json

because i am cruel

* style(autofix.ci): automated formatting

* Update specials.json

* Update data/json/overmap/overmap_special/specials.json

Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>

---------

Co-authored-by: John Bytheway <52664+jbytheway@users.noreply.github.com>
Co-authored-by: Eric Pierce <238395+wapcaplet@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants