Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Pipfile.lock from repository. Rely on the cached and in artifact… #1314

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Drop Pipfile.lock from repository. Rely on the cached and in artifact… #1314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/linters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ jobs:
lint:
uses: fizyk/actions-reuse/.github/workflows/linters-python.yml@v2.4.2
with:
pipenv-install-options: "--skip-lock"
mypy: true
black: true
ruff: true
2 changes: 0 additions & 2 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
- uses: fizyk/actions-reuse/.github/actions/pipenv@v2.4.2
with:
python-version: "3.11"
pipenv-install-options: "--skip-lock"
command: tbump --dry-run --only-patch $(pipenv run tbump current-version)"-x"
towncrier:
runs-on: ubuntu-latest
Expand All @@ -22,6 +21,5 @@ jobs:
- uses: fizyk/actions-reuse/.github/actions/pipenv@v2.4.2
with:
python-version: "3.11"
pipenv-install-options: "--skip-lock"
command: towncrier check --compare-with origin/main
fetch-depth: 0
2 changes: 0 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,10 @@ jobs:
- uses: fizyk/actions-reuse/.github/actions/pipenv@v2.4.2
with:
python-version: ${{ matrix.python-version }}
pipenv-install-options: "--skip-lock"
command: pytest -n 0 --cov-report=xml
- uses: fizyk/actions-reuse/.github/actions/pipenv@v2.4.2
with:
python-version: ${{ matrix.python-version }}
pipenv-install-options: "--skip-lock"
command: pytest -n 1 --cov-report=xml:coverage-xdist.xml
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4.1.0
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ develop-eggs
lib
lib64

# Pipenv
Pipfile.lock

# Installer logs
pip-log.txt

Expand Down
983 changes: 0 additions & 983 deletions Pipfile.lock
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions newsfragments/1314.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Rely on cached/artifacted Pipfile.lock. This allows to use pipenv seamlessly on more than single python versions.
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ showcontent = true

[tool.towncrier.fragment.misc]
name = "Miscellaneus"
showcontent = true
showcontent = false

[tool.tbump]
# Uncomment this if your project is hosted on GitHub:
Expand Down
Loading