Merge pull request #1314 from ClearcodeHQ/pipfile

Drop Pipfile.lock from repository. Rely on the cached and in artifact…
ClearcodeHQ · Mar 11, 2024 · 1044fa2 · 1044fa2
2 parents 929a4ea + c7e88c8
commit 1044fa2
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 989 deletions.
diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml
@@ -10,7 +10,6 @@ jobs:
   lint:
     uses: fizyk/actions-reuse/.github/workflows/linters-python.yml@v2.4.2
     with:
-      pipenv-install-options: "--skip-lock"
       mypy: true
       black: true
       ruff: true
diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
@@ -13,7 +13,6 @@ jobs:
       - uses: fizyk/actions-reuse/.github/actions/pipenv@v2.4.2
         with:
           python-version: "3.11"
-          pipenv-install-options: "--skip-lock"
           command: tbump --dry-run --only-patch $(pipenv run tbump current-version)"-x"
   towncrier:
     runs-on: ubuntu-latest
@@ -22,6 +21,5 @@ jobs:
       - uses: fizyk/actions-reuse/.github/actions/pipenv@v2.4.2
         with:
           python-version: "3.11"
-          pipenv-install-options: "--skip-lock"
           command: towncrier check --compare-with origin/main
           fetch-depth: 0
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -31,12 +31,10 @@ jobs:
     - uses: fizyk/actions-reuse/.github/actions/pipenv@v2.4.2
       with:
         python-version: ${{ matrix.python-version }}
-        pipenv-install-options: "--skip-lock"
         command: pytest -n 0 --cov-report=xml
     - uses: fizyk/actions-reuse/.github/actions/pipenv@v2.4.2
       with:
         python-version: ${{ matrix.python-version }}
-        pipenv-install-options: "--skip-lock"
         command: pytest -n 1 --cov-report=xml:coverage-xdist.xml
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v4.1.0

diff --git a/.gitignore b/.gitignore
@@ -21,6 +21,9 @@ develop-eggs
 lib
 lib64
 
+# Pipenv
+Pipfile.lock
+
 # Installer logs
 pip-log.txt
 

diff --git a/Pipfile.lock b/Pipfile.lock
diff --git a/newsfragments/1314.misc.rst b/newsfragments/1314.misc.rst
@@ -0,0 +1 @@
+Rely on cached/artifacted Pipfile.lock. This allows to use pipenv seamlessly on more than single python versions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -94,7 +94,7 @@ showcontent = true
 
 [tool.towncrier.fragment.misc]
 name = "Miscellaneus"
-showcontent = true
+showcontent = false
 
 [tool.tbump]
 # Uncomment this if your project is hosted on GitHub: