-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy to the linting step. #271
Conversation
Address mypy issues. Add CONTRIBUTING.md file.
Tests are failing in CI, I'll reproduce locally and will fix. |
For some reason the Ci check for Windows/Py36 got stuck and is still in progress after several hours. I cannot abort it, maybe you can: https://github.com/CleanCut/green/actions/runs/4921522632 To avoid this issue I added a timeout for the CI check. I've added |
Add 15m timeout to CI checks. Update CI checks to pip install green in developer mode.
The issue with the windows CI check is that I added a tearDown to test_integration.py to cleanup the temp directory. On Windows with Python 3.6 an other process is accessing the same folder somehow, although it is supposed to be a unique folder. Note that the macOS Py 3.11 check is taking 4-6m to pip install and it seems to be because it needs to compile lxml from source as a universal binary. @CleanCut let me know if you have any issues with the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making good progress. 😄
Co-authored-by: Nathan Stocks <cleancut@github.com>
@CleanCut There is an ongoing GitHub incident with Actions being impacted. It has been very unstable this week with 3 separate incidents just yesterday. Feel free to restart the check once the incidents are over, you have more details on this than I do ;-) |
@CleanCut sorry to nag you, but is there anything else you need me to update here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Address mypy issues.
Add CONTRIBUTING.md file.