api: fix wait_for_transaction_receipt for neo-go nodes #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, implementation of neo-project/proposals#156 for both NeoC# and NeoGo will solve the first problem. And we have nspcc-dev/neo-go#3063 in progress, the error text for this case won't be changed, but it will have a special error code. |
|
if only they'd move the PR forward before 2030 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neo-gonodes return a different error message when a transaction cannot be found. Which breaks thewait_for_transaction_receipt()helper function.neo-gowhen asking for a transaction that does not exist (e.g. because the block is not yet processed) an error is expected. However, the neo-go nodes do not set thecontent-typeof the response toapplication/jsonlike the C# nodes do. This causes a failed content-type check during the conversion to JSON usingaiohttp. This PR also disables content-type checking in the RPC client.