Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar chart tests #580

Merged
merged 1 commit into from
Nov 29, 2015
Merged

Bar chart tests #580

merged 1 commit into from
Nov 29, 2015

Conversation

alvesjtiago
Copy link
Contributor

Bar chart tests included mimicking previous line chart tests. Updated
ios-snapshot-test-case to 2.0.7 version.
Bar chart tests include:

  • default chart
  • hide values
  • hide left axis
  • hide right axis
  • hide left axis gridlines
  • hide right axis gridlines

Bar chart tests included mimicking previous line chart tests. Updated
ios-snapshot-test-case to 2.0.7 version.
Bar chart tests included:
- default chart
- hide values
- hide left axis
- hide right axis
- hide left axis gridlines
- hide right axis gridlines
override func tearDown()
{
// Put teardown code here. This method is called after the invocation of each test method in the class.
super.tearDown()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit picking: no need to override tearDown here to just call super. Boiler plate code probably ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right @yas375, I just reused the code from the LineChartTests but I will refactor it to a single data generation file and keep the specifics to each of the tests. As well as removing the tearDown override :) thank you

@yas375
Copy link
Contributor

yas375 commented Nov 29, 2015

Cool! 👍

danielgindi added a commit that referenced this pull request Nov 29, 2015
@danielgindi danielgindi merged commit 3f88894 into ChartsOrg:master Nov 29, 2015
@danielgindi
Copy link
Collaborator

Thanks :-)

@alvesjtiago alvesjtiago deleted the bar-chart-tests branch November 29, 2015 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants