Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove swift-algorithms package in favor of manully importing needed … #5069

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

pmairoldi
Copy link
Collaborator

@pmairoldi pmairoldi commented Jun 8, 2023

Removed the need for swift-algorithms.

We were using only 2 functions so I duplicated the source code into our codebase. We now own this and do not have dependencies.

Addresses #4919 & #4938

@liuxuan30
Copy link
Member

@pmairoldi, just asking, it seems builds fine, are you having problems still and have to remove the packages?

@pmairoldi
Copy link
Collaborator Author

Don't think so. I removed everything.

@liuxuan30
Copy link
Member

what don't compile?

@pmairoldi
Copy link
Collaborator Author

Nothing but it's more to fix the Bitcode and build for distribution errors. We use only 2 functions. I'd rather own the code than have a dependency for such a small thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants