Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AxisBase Formatter Getter (Fixes #4365) #4366

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

giantramen
Copy link

Fixes issue where if you overrode the
formatter it didn't matter because a new one would
just replace it.

Issue Link #4365

Fixes issue where if you overrode the
formatter it didn't matter because a new one would
just replace it.
@giantramen
Copy link
Author

@liuxuan30 Would you mind reviewing (or adding someone to review) this?

@liuxuan30
Copy link
Member

can you give some context why this change? e.g. If you set the formatter first, the old should work.

@liuxuan30 liuxuan30 self-assigned this Jun 8, 2020
@giantramen
Copy link
Author

I am a little confused by what you're asking for.
"Fixes issue where if you overrode the
formatter it didn't matter because a new one would
just replace it."

@liuxuan30
Copy link
Member

Ah at first I mean I didn't clearly see why old code not work. but in your case, are you saying that when you have a formatter and meet the condition, it will create a new one, so some of your properties will be lost? is this correct?

@liuxuan30 liuxuan30 merged commit 8c97cb1 into ChartsOrg:master Jun 22, 2020
mosaic-engineering pushed a commit to mosaic-io/Charts that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants