Uses guard instead of if #3330
Closed
Uses guard instead of if #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3330 +/- ##
=======================================
Coverage 28.32% 28.32%
=======================================
Files 117 117
Lines 15669 15669
Branches 320 320
=======================================
Hits 4438 4438
Misses 11188 11188
Partials 43 43Continue to review full report at Codecov.
|
jjatie
reviewed
Mar 15, 2018
| @@ -99,7 +99,7 @@ class LineChart1ViewController: DemoBaseViewController { | |||
| } | |||
|
|
|||
| override func updateChartData() { | |||
| if self.shouldHideData { | |||
| guard !self.shouldHideData else { | |||
There was a problem hiding this comment.
if makes sense here, but should be
if shouldHideData {
// Hide the data...
} else {
// Show the data
}
|
@valeriyvan take a look at my comment on #3327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.