Allow vcpkg overlays to be specified as CMake variables #946
+40
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of env variables
|
@lilleyse I'll investigate. I haven't actually done anything overlay specific with ezvcpkg or vcpkg in general yet, so I have little experience. This change seems straightforward enough though. If you want to create a PR I'll likely merge it quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently projects using cesium-native set
VCPKG_OVERLAY_PORTSandVCPKG_OVERLAY_TRIPLETSas environment variables. This PR allows you to instead set them as regular CMake variables, like what we do forVCPKG_TRIPLET.@jherico would this be a welcome change to bring back into https://github.com/jherico/ezvcpkg?