Enable search box geocoder provider selection #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanmalagon
approved these changes
Jan 21, 2019
| @@ -67,11 +67,13 @@ var Search = View.extend({ | |||
| }, | |||
|
|
|||
| _initializeGeocoder: function () { | |||
| this.geocoderService = this.options.geocoderService || DEFAULT_GEOCODER; | |||
| const injectedGeocoderConfig = this._getGeocodingInfoFromConfig(); | |||
There was a problem hiding this comment.
The only thing that tingles my spidey sense is the mix of configurations.
I can get the provider from the injected config but the token can be undefined and then I go directly for the window property... those combinations.
That won't break the code but if a configuration is wrong perhaps it makes it harder to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow us to select the geocoding provider for the search box overlay in Builder by injecting
geocodingConfigurationvariable containing the needed configuration into window scope.Mirror PR from
cartodb: CartoDB/cartodb#14622Related to #2223.