Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hexagon aggregation example #2151

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Conversation

oriolbx
Copy link
Contributor

@oriolbx oriolbx commented Jun 22, 2018

Add Leaflet and Gmaps example of point aggregation with hexagon aggregation

@oriolbx oriolbx requested a review from inigomedina June 22, 2018 13:25
Copy link
Contributor

@ivanmalagon ivanmalagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want these example to show up in the developer center, you must write them in examples.json.

If not, let me know.

@oriolbx
Copy link
Contributor Author

oriolbx commented Jun 22, 2018

done @ivanmalagon :)

Copy link
Contributor

@inigomedina inigomedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oriolbx, as a common rule of styling, for a better understanding, add comments to each code block so that users can easily understand them.

@oriolbx
Copy link
Contributor Author

oriolbx commented Jun 25, 2018

Ok, this is not on the rest of examples, that means that we would need to modify all existing examples with comments for each block of code, right?

@ivanmalagon ivanmalagon merged commit ed37be2 into master Jun 25, 2018
@ivanmalagon ivanmalagon deleted the dev-center-examples-aggregattion branch June 25, 2018 10:57
@ivanmalagon
Copy link
Contributor

I've merged this PR but it won't be published to docs until another PR with code gets merged.

We did a change to avoid differences between docs and code and we need to publish a tag in order to reflect changes in docs.

Since we're in active development of v4.1 this isn't a problem. We're going to merge code these days.

@oriolbx
Copy link
Contributor Author

oriolbx commented Jun 25, 2018

Great! Thanks for the info! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants