Fix margins on legends

[jesusbotella]

This PR fixes margins and spacing on legends, specially on Bubble legend.

The problem was that the legend was taking more space than what it has assigned due to absolute positioning. So the margins were collapsed, appearing misaligned.

Acceptance

See https://github.com/CartoDB/support/issues/1566

Related to https://github.com/CartoDB/support/issues/1566

[houndci-bot]

Shorthands of length 4 are not allowed. Value was 16px 0 10px 0
Shorthand form for property margin should be written more concisely as 16px 0 10px instead of 16px 0 10px 0

[rubenmoya]

Code looks good, but we have to do a really good acceptance since we've been fixing bugs on legends for the last 2 months...

[rubenmoya]

[jesusbotella]

💥

[arianaescobar]

The margin error is fixed, but I found some other weird behaviors about the legends but unrelated to the margins. Should I open another issue or share them here?

[jesusbotella]

@arianaescobar Can you open a new issue with the things you found, please? :)

[arianaescobar]

Sure!

[arianaescobar]

I'm just going to share one of those here because it might be related.

In the embed, if I collapse the legends, an extra margin appears on the bottom.

[jesusbotella]

Yes, I have just checked the last change of that behaviour and it was 2 months ago. So, I can do the change but seems like it was done on purpose 🤔

[arianaescobar]

"🤔" indeed

[jesusbotella]

I don't get your last comment 😂. Do you want me to change that margin?

[ramiroaznar]

The RT has dealt with lots of bug-legends, look at support or cartodb repos and you will find the culprit.

[arianaescobar]

@jesusbotella Yes, change it please 🙂 it should be the same margin on each side.

[jesusbotella]

@arianaescobar I have just noticed that the margin change needs to be done in Builder, so I am gonna open a new issue for that. I'll link it in here once it is opened.