Add new methods to cartoDB layer #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This methods allow to solve https://github.com/CartoDB/support/issues/1399
elenatorro
reviewed
May 8, 2018
src/geo/map/cartodb-layer.js
Outdated
| @@ -147,6 +147,16 @@ var CartoDBLayer = LayerModelBase.extend({ | |||
| remove: function () { | |||
| this.getSource().unmarkAsSourceOf(this); | |||
| LayerModelBase.prototype.remove.apply(this, arguments); | |||
| }, | |||
|
|
|||
| $getTableName: function () { | |||
There was a problem hiding this comment.
I would add some tests for $getTableName and $getApiKey.
In addition, but this is a personal opinion, I would return null if there are not this.attributes.source.attributes.options. If the result of this function is assigned to a value, this value would be undefined, and I consider that is more correct to set it to null instead of undefined.
elenatorro
approved these changes
May 8, 2018
ivanmalagon
suggested changes
May 8, 2018
src/geo/map/cartodb-layer.js
Outdated
| }, | ||
|
|
||
| $getTableName: function () { | ||
| if (this.attributes.source.attributes.options) { |
There was a problem hiding this comment.
Two things:
- Instead of accessing
this.attributesuse thegetmethod (general tip for Backbone models). In this case, you can use the existinggetSource(). - This is an internal class and we are not following the
$convention that we use in the public API.
ivanmalagon
reviewed
May 8, 2018
| }, | ||
|
|
||
| getTableName: function () { | ||
| if (this.get('source').has('options')) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This methods help to solve https://github.com/CartoDB/support/issues/1399