Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Ck2yaml crashes if reaction equation has both ThreeBodyReaction and Falloff reaction types #855

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fixed: Ck2yaml crashes if reaction equation has both ThreeBodyReaction and Falloff reaction types #855

merged 1 commit into from
Jun 2, 2020

Commits on Jun 2, 2020

  1. Fixed: Ck2yaml crashes if reaction equation has both ThreeBodyReactio… 

    …n and Falloff reaction types

Bug: check_duplicate_reactions breaks if sent a third body reaction and falloff reaction because r1.third_body (or r2) is None and has no attribute upper.

Fix: This changes the third body reaction type to have a .third_body of M and then in check_duplicate_reactions check that r1 and r2 are not a mixture of three body reaction type and something else.

Bug: if blank space in header, parser crashes due to regular expression search to determine indent size

Fix: check that the comment is not empty before trying to determine indent size

Improvement: inform user which reaction contains multiple reaction types

Added Tests for both issues fixed
    @tsikes @bryanwweber
    tsikes authored and bryanwweber committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    60c978c View commit details
    Browse the repository at this point in the history