Deprecate undocumented Butler-Volmer reaction options #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
==========================================
- Coverage 70.83% 70.81% -0.03%
==========================================
Files 372 372
Lines 43720 43733 +13
==========================================
Hits 30971 30971
- Misses 12749 12762 +13
Continue to review full report at Codecov.
|
|
Agreed, particularly as there is a bit of 'philosophical' discussion to be hashed out about how we'd like to best implement and support this functionality. No need for those discussions to hold up the release of other functionality, at present. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #749, I believe that there are implementation issues that prevent most if not all of it from being used at present (for both 2.4.0 and the current master branch) due to two mutually-exclusive conditions: (a) we don't currently allow reactant orders to be specified for reversible reactions and (b) Butler-Volmer reactions are required to be reversible and involve manipulating the reaction orders.
I think the easiest path forward to supporting these Butler-Volmer and other reaction types is to deprecate and remove these non-functional versions, and re-consider implementation after the next release.