Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yaml-cpp to the shared libraries if building with system yaml-cpp #671

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Add yaml-cpp to the shared libraries if building with system yaml-cpp #671

merged 3 commits into from
Aug 1, 2019

Commits on Aug 1, 2019

  1. [SCons] Add yaml-cpp to shared libraries if building with system yaml… 

    …-cpp

If building Cantera with system_yamlcpp=y the yaml-cpp library needs to be
specified in the linker flags.

Fixes Cantera#668
    @spinnau @speth
    spinnau authored and speth committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    1f349e0 View commit details
    Browse the repository at this point in the history

  2. [SCons] Link to yaml-cpp when using system libs 

    Similar to the system_sundials option, libyaml-cpp must be added to the
linker line when the system libraries are used.
    @bryanwweber @speth
    bryanwweber authored and speth committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    f98b120 View commit details
    Browse the repository at this point in the history

  3. [SCons] Remove fmt from linking 

    We use the header-only version of fmt now, so no need to link to the
compiled library.
    @bryanwweber @speth
    bryanwweber authored and speth committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    6ecd5ad View commit details
    Browse the repository at this point in the history