-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement function to list data files #589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this change! A few changes to request. When you make them, please squash all of your changes into one commit and force push to this branch to update the pull request.
@CyberDrudge Thank you for the quick fixes! Can you squash the three commits here into one commit and force-push to this branch? If you need help with that, just let me know 😄 Thanks! |
2f18974
to
e128b65
Compare
@bryanwweber no worries, a bit of googling showed me the way. |
@speth The function here is named @CyberDrudge Can you please add documentation to this function? It would look something like def files(ext=''):
"""
Overall description of what this function does.
:param ext:
Description of what the ext argument does
""" Thanks! |
Changed function name and added Documentation. I will edit name and squash changes if required. |
Update function to list data files Follow Style Guidelines Add doc for listing files
@bryanwweber does this still require any updates before it gets merged? |
Fixes #586
Function
cantera.data.files()
returns list of all data files. It can also be used to get files of a certain type by specifying the required extension.