Replace stylevalue 'setlinewidth' together with style attribute by 'penwidth'

[tilmanbremer]

Changes proposed in this pull request:

• setlinewidth is deprecated (http://graphviz.org/content/attrs#style)
• Fixes that the cantera user cannot use style argument for edges in the command line e.g. -Estyle="dashed"

[codecov]

Codecov Report

Merging #463 into master will decrease coverage by <.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   58.23%   58.23%   -0.01%     
==========================================
  Files         386      386              
  Lines       42310    42309       -1     
  Branches     7252     7252              
==========================================
- Hits        24640    24639       -1     
  Misses      15488    15488              
  Partials     2182     2182

Impacted Files	Coverage Δ
src/kinetics/ReactionPath.cpp	71.88% <57.14%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf74d1...49aa58b. Read the comment docs.

[speth]

Thanks for the clear and clean PR. It looks like this does just what it needs to, and I don't see any problems except with ancient versions of Graphviz.

[tilmanbremer]

I tried to keep it simple, because this was my first pull-request ever. Thanks for approving it. This was a result of my attempt to provide a better documentation for the reaction path diagram feature of cantera (https://www.tilmanbremer.de/2017/06/tutorial-generating-reaction-path-diagrams-with-cantera-and-python/). I will try to make more sophisticated commits to ReactionPath.cpp soon.

[santoshshanbhogue]

Wov, Tilman, this is super useful! Thanks for the detailed tutorial. Hopefully the admins can add this to the cantera documentation Regards Santosh

…

On Thu, Jul 13, 2017 at 4:18 AM Tilman ***@***.***> wrote: I tried to keep it simple, because this was my first pull-request ever. Thanks for approving it. This was a result of my attempt to provide a better documentation for the reaction path diagram feature of cantera ( https://www.tilmanbremer.de/2017/06/tutorial-generating-reaction-path-diagrams-with-cantera-and-python/). I will try to make more sophisticated commits to ReactionPath.cpp soon. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#463 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AM-6FPinvHnizxmNZKFQ1AcY7Xpo7bNDks5sNdLVgaJpZM4OLR4Y> .

[tilmanbremer]

Thank you Santosh. I would like to contribute to the official docs, too, but I believe it makes more sense to improve the whole reaction path functionality first, and then update the docs accordingly. So the tutorial was a way for me to really dive into the current situation, now I hopefully can improve it from here.

[speth]

The current reaction path code is certainly in need of a major overhaul, as well as better documentation. Any improvements in this area would certainly be welcome. One thing I've been meaning to look into but haven't had the time is how RMG generates its flux diagrams, which are very nice looking compared to the clunky ones that Cantera currently generates (see for example the one on the rmg.mit.edu homepage).