Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tpx citations #1575

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Add tpx citations #1575

merged 3 commits into from
Aug 8, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 8, 2023

Changes proposed in this pull request

  • Add doxygen references for tpx pure substances.
  • Add doxygen references for FalloffRate specializations
  • Add doxygen reference for NASA 9-coefficient polynomials

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl marked this pull request as draft August 8, 2023 03:44
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1575 (1807e03) into main (1f580a3) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
+ Coverage   70.49%   70.53%   +0.04%     
==========================================
  Files         379      379              
  Lines       59110    59110              
  Branches    21232    21232              
==========================================
+ Hits        41671    41695      +24     
+ Misses      14363    14340      -23     
+ Partials     3076     3075       -1     
Files Changed Coverage Δ
include/cantera/kinetics/Falloff.h 81.63% <ø> (ø)
include/cantera/thermo/Nasa9Poly1.h 0.00% <ø> (ø)
src/tpx/CarbonDioxide.h 100.00% <ø> (ø)
src/tpx/HFC134a.h 100.00% <ø> (ø)
src/tpx/Heptane.h 100.00% <ø> (ø)
src/tpx/Hydrogen.h 100.00% <ø> (ø)
src/tpx/Methane.h 100.00% <ø> (ø)
src/tpx/Nitrogen.h 100.00% <ø> (ø)
src/tpx/Oxygen.h 100.00% <ø> (ø)
src/tpx/Water.h 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ischoegl ischoegl marked this pull request as ready for review August 8, 2023 05:15
@ischoegl ischoegl requested a review from a team August 8, 2023 11:26
include/cantera/kinetics/Falloff.h Outdated Show resolved Hide resolved
Ensure that docstrings are consistent with science section
@speth speth merged commit 277bce0 into Cantera:main Aug 8, 2023
42 checks passed
@ischoegl ischoegl deleted the reynolds branch August 8, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants