-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak SolutionArray IO #1458
Tweak SolutionArray IO #1458
Conversation
a6bca43
to
ccc38d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1458 +/- ##
==========================================
- Coverage 69.91% 69.86% -0.05%
==========================================
Files 377 377
Lines 57262 57298 +36
Branches 19151 19164 +13
==========================================
- Hits 40036 40033 -3
- Misses 14676 14712 +36
- Partials 2550 2553 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ccc38d9
to
57d427a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ischoegl. I'm definitely pleased to see the loglevel
flag go away in these instances. I just had one naming suggestion, and a point of clarification on checkGroup
, which may suggest some additional documentation for that method.
57d427a
to
45d29c7
Compare
@speth and @bryanwweber ... thanks for the reviews! I believe all concerns are addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ischoegl. This looks good to me.
Changes proposed in this pull request
This PR takes introduces minor improvements to the API after the merge of #1426
loglevel
inSim1D::save/restore
SolutionArray::save
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage