Fix issues identified by _GLIBCXX_ASSERTIONS and various build warnings #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in macOS 13.2, the use of sprintf started generating deprecation warnings, even though it's not deprecated by the C++ standard.
speth
force-pushed
the
fix-glibcxx-assertions
branch
2 times, most recently
from
7fd9fdc
to
270482f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1441 +/- ##
=======================================
Coverage 70.92% 70.92%
=======================================
Files 369 369
Lines 55227 55232 +5
Branches 18194 18196 +2
=======================================
+ Hits 39171 39176 +5
Misses 13595 13595
Partials 2461 2461
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Setuptools started giving the warning: "Installing 'cantera.test' as data is deprecated, please list it in `packages`." for the data, test, and examples directories.
speth
force-pushed
the
fix-glibcxx-assertions
branch
from
270482f
to
ec523de
Compare
ischoegl
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
_GLIBCXX_ASSERTIONSmacro definedIf applicable, fill in the issue number this pull request is fixing
Closes #1430
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage