Cleaning up the redundant line inside the for loop in evalSurfaces() #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischoegl
reviewed
Feb 17, 2023
There was a problem hiding this comment.
LGTM, although only after checking
cantera/src/zeroD/ReactorNet.cpp
Line 276 in 3d43413
... I assume that there never was an intent to change LHS values in this loop? I'm wondering whether setting
LHS[loc] = 1.0 on line 302/303 is required at all.
ischoegl
previously approved these changes
Feb 17, 2023
|
Yes, I agree, the statement |
|
I just removed the other line as well. |
ischoegl
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The LHS array in
evalSurfaces()is set to 1 by default. The lineLHS[loc] = 1inside the for loop is removed, as it is redundant and confusing.