Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scons] Remove "install" target from "check_for_pytest" #1434

Merged
merged 1 commit into from
Feb 11, 2023

Commits on Feb 10, 2023

  1. [Scons] Remove "install" target from "check_for_pytest"

    The `check_for_pytest` depends on `check_for_ruamel_yaml`
    the pytest package is required on `install` phase and it results in
    the Cantera installation fail if pytest absent
    even if tests were not required.
    
    This patch swap `check_for_pytest` and `check_for_ruamel_yaml`
    dependency order.
    
    The explicit `test-python-convert`, `test-python` targets are dropped
    from `check_for_ruamel_yaml` because the `check_for_pytest`
    includes `target.startswith("test-python")`.
    
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    band-a-prend committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    230f700 View commit details
    Browse the repository at this point in the history