Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI for .NET interface #1401

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Run CI for .NET interface #1401

merged 4 commits into from
Nov 4, 2022

Conversation

speth
Copy link
Member

@speth speth commented Oct 1, 2022

Changes proposed in this pull request

  • Test the .NET interface on Windows, Linux, and macOS
  • Include coverage of the C++ code generated by the .NET tests
  • TODO: add code coverage for .NET code

If applicable, fill in the issue number this pull request is fixing

Closes #

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #1401 (3af03d3) into main (f1d86d1) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
+ Coverage   71.06%   71.15%   +0.08%     
==========================================
  Files         363      373      +10     
  Lines       51911    52281     +370     
  Branches    17374    17374              
==========================================
+ Hits        36890    37198     +308     
- Misses      12674    12728      +54     
- Partials     2347     2355       +8     
Impacted Files Coverage Δ
...terfaces/dotnet/Cantera/src/Interop/InteropUtil.cs 60.75% <0.00%> (ø)
interfaces/dotnet/Cantera/src/Application.cs 93.87% <0.00%> (ø)
interfaces/dotnet/Cantera/src/ExtensionMethods.cs 100.00% <0.00%> (ø)
interfaces/dotnet/Cantera/src/Enums.cs 91.66% <0.00%> (ø)
interfaces/dotnet/Cantera/src/SpeciesCollection.cs 32.40% <0.00%> (ø)
interfaces/dotnet/Cantera/src/Species.cs 58.33% <0.00%> (ø)
interfaces/dotnet/Cantera/src/Exceptions.cs 100.00% <0.00%> (ø)
interfaces/dotnet/Cantera/src/ThermoPhase.cs 32.50% <0.00%> (ø)
...rfaces/dotnet/Cantera/src/Interop/CanteraHandle.cs 78.57% <0.00%> (ø)
...aces/dotnet/Cantera/src/DataDirectoryCollection.cs 91.30% <0.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth speth marked this pull request as ready for review October 29, 2022 16:18
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speth … thanks! This looks good to me.

@ischoegl ischoegl merged commit 9f4e644 into Cantera:main Nov 4, 2022
@ischoegl ischoegl mentioned this pull request Nov 4, 2022
5 tasks
@speth speth deleted the dotnet-ci branch November 4, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants