Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept floating point representations of valid integer geometry flags in ck2yaml #1396

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Accept floating point representations of valid integer geometry flags in ck2yaml #1396

merged 2 commits into from
Jan 24, 2023

Commits on Jan 24, 2023

  1. Allow float input of integer geometry flags in ck2yaml 

    If `permissive` is given, `float` geometry flags are cast to `int` and are accepted if the values are equal, otherwise, `InputError` is raised. If `permissive` is not given, existing behavior is unchanged.

Add tests to check for correct behavior with and without permissive, for float rounding error, and for character inputs.

Closes Cantera#1395
    @corykinney
    corykinney committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a90dc63 View commit details
    Browse the repository at this point in the history

  2. Add Pycharm to .gitignore 

    Ignore `.idea/` folder associated with PyCharm IDE data
    @corykinney
    corykinney committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    824d890 View commit details
    Browse the repository at this point in the history