Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scons] Ignore missing pytest with minimal python module #1364

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

speth
Copy link
Member

@speth speth commented Aug 11, 2022

Changes proposed in this pull request

  • Allow scons test to continue without having pytest when using the option python_package=minimal

If applicable, fill in the issue number this pull request is fixing

See comment in #1360.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth marked this pull request as ready for review August 12, 2022 02:22
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth - this looks good to me!

@ischoegl ischoegl merged commit 235d843 into Cantera:main Aug 12, 2022
@speth speth deleted the python-coverage branch July 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants