Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update three body logic #1338

Merged
merged 11 commits into from
Jul 24, 2022
Merged

Update three body logic #1338

merged 11 commits into from
Jul 24, 2022

Commits on Jul 18, 2022

  1. [Kinetics] Implement override of three-body detection logic

    @ischoegl
    ischoegl committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    1dd6bfe View commit details
    Browse the repository at this point in the history

  2. [Kinetics] Allow alternative explicit three-body reaction types

    @ischoegl
    ischoegl committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    6d1fd16 View commit details
    Browse the repository at this point in the history

  3. [Kinetics] Detection and serialization of Reaction edge cases

    @ischoegl
    ischoegl committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    e917ef7 View commit details
    Browse the repository at this point in the history

  4. [UnitTests] Cover edge cases for three-body reaction logic

    @ischoegl
    ischoegl committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    b9eb64c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. [Kinetics] Update error messages and comments

    @ischoegl
    ischoegl committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    908790b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. [Kinetics] Cover additional edge cases

    @ischoegl
    ischoegl committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    0dfdf05 View commit details
    Browse the repository at this point in the history

  2. [Python] Block generic kwargs in Reaction constructor

    @ischoegl
    ischoegl committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    ae1af13 View commit details
    Browse the repository at this point in the history

  3. [UnitTests] Addition third-body collider tests

    @ischoegl
    ischoegl committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    8fdac85 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. Address review comments

    @ischoegl
    ischoegl committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    123e392 View commit details
    Browse the repository at this point in the history

  2. [Kinetics] Enforce zero default efficiency for explicit third body

    @ischoegl
    ischoegl committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    e0b0ec9 View commit details
    Browse the repository at this point in the history

  3. [UnitTests] Update three-body unit tests

    @ischoegl
    ischoegl committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    ced29d7 View commit details
    Browse the repository at this point in the history