Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Units] Add Cython interface for some functions #1285

Merged
merged 2 commits into from
May 30, 2022

Conversation

bryanwweber
Copy link
Member

These functions are chosen for their potential utility. Setting units is
not enabled by this interface because it is meant to be handled
internally. However, these methods can help to determine the unit
factors for reaction rates.

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dove-tails nicely with #1076. I have one minor suggestion ...

interfaces/cython/cantera/units.pyx Outdated Show resolved Hide resolved
@bryanwweber bryanwweber force-pushed the add-units-helpers branch 2 times, most recently from 3284bc8 to fe2dd53 Compare May 26, 2022 14:54
These functions are chosen for their potential utility. Setting units is
not enabled by this interface because it is meant to be handled
internally. However, these methods can help to determine the unit
factors for reaction rates.
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - LGTM!

@ischoegl ischoegl merged commit aef1843 into Cantera:main May 30, 2022
@bryanwweber bryanwweber deleted the add-units-helpers branch August 2, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants