Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent aggressive pip uninstallation of existing package #1239

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

speth
Copy link
Member

@speth speth commented Apr 6, 2022

Changes proposed in this pull request

  • Determine whether the Python module is being re-installed to the same location. If not, add the --ignore-installed option to pip install

If applicable, fill in the issue number this pull request is fixing

Fixes #1230

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth force-pushed the fix-1230-pip-uninstall branch 2 times, most recently from 2a74ad9 to 493462e Compare April 6, 2022 17:32
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptively approving. @bryanwweber, please raise objections as necessary ... 😉

@ischoegl ischoegl merged commit 0d29d6a into Cantera:main Apr 7, 2022
@speth speth mentioned this pull request Apr 17, 2022
5 tasks
@speth speth deleted the fix-1230-pip-uninstall branch July 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install procedure tries to uninstall Cantera-python version installed by system pkg manager
2 participants