Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify creation of interface phases #1169

Merged
merged 16 commits into from
Jan 19, 2022
Merged

Simplify creation of interface phases #1169

merged 16 commits into from
Jan 19, 2022

Commits on Jan 18, 2022

  1. Deprecate unnecessary Phase::setRoot method

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    5584e91 View commit details
    Browse the repository at this point in the history

  2. Fix syntax error in silane.yaml deprecation

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    87d6fc6 View commit details
    Browse the repository at this point in the history

  3. [Thermo] Make phaseNode argument const

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    97e2125 View commit details
    Browse the repository at this point in the history

  4. [Test] Remove redundant blessed output files

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    a53457d View commit details
    Browse the repository at this point in the history

  5. [Solution] Automatically instantiate adjacent phases

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    4aea7f9 View commit details
    Browse the repository at this point in the history

  6. Add Interface class as a specialized version of Solution 

    This class provides access to the thermo and kinetics objects as the
correct derived types, i.e. SurfPhase and InterfaceKinetics, so
methods defined only for these derived types can be called easily.
    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    155df8d View commit details
    Browse the repository at this point in the history

  7. [Solution] Handle multiple levels of adjacent phases

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    909172b View commit details
    Browse the repository at this point in the history

  8. [Input] Add adjacent-phases handling to YamlWriter

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    01ba90f View commit details
    Browse the repository at this point in the history

  9. [Thermo] Add file-based constructor for EdgePhase

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    3b74ca3 View commit details
    Browse the repository at this point in the history

  10. [Python] Add adjacent phase handling to Python interface

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    7d5e76a View commit details
    Browse the repository at this point in the history

  11. [Test] Fix sticking coeff error test in debug mode 

    The error message from the second reaction containing an error will
not be encountered because parsing stops after the first invalid reaction
when in debug mode.
    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    b3dbce8 View commit details
    Browse the repository at this point in the history

  12. Update C++ tests to use new adjacent phase handling

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    f9463ee View commit details
    Browse the repository at this point in the history

  13. Include adjacent phase info when converting mechs

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    138a519 View commit details
    Browse the repository at this point in the history

  14. [Python] Use new adjacent phase handling in examples

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    a9bc472 View commit details
    Browse the repository at this point in the history

  15. Improve test coverage of Interface class

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    8c2e3d1 View commit details
    Browse the repository at this point in the history

  16. Add test for detection of deprecated phase names

    @speth
    speth committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    5e2e8d4 View commit details
    Browse the repository at this point in the history