Update example mechs #1109
Merged
Update example mechs #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test errors with Sundials 2 and Sundials 5.7 appear related to h5py. |
ischoegl
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
@mefuller ... thank you for looking into this. This PR replaces GRI-Mech 3.0 where only the H2-O2 submechanism is used as no carbon species are involved. There are likely some examples where the reactant mixture could be simplified, but this arguably goes beyond the scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Where appropriate, the example mechanism has been changed from gri30 to ohmech
Closes #932
Checklist
scons build&scons test) and unit tests address code coverage