-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C++ tutorial #192
Update C++ tutorial #192
Conversation
b8d0fce
to
d690ded
Compare
@speth ... ended up replacing |
725c735
to
0e14050
Compare
Fwiw, some of the includes can be simplified if Cantera/cantera#1238 were to be adopted. |
As @speth mentioned elsewhere, I don't think now is a good time to get into a conversation about the content of the include files. I'd prefer not dropping the lowercase include files from the examples. I think we should limit this PR to the changes in the |
@bryanwweber ... thank you for the comments.
I'm totally fine with keeping 'convenience' headers. At the same time, not having
I'm not sure I agree here: My preferred solution would be to switch the imports to #include "cantera/core.h" as proposed in PR Cantera/cantera#1238 (will wait on feedback there). PS: If Cantera/cantera#1238 goes ahead, I'd redirect this PR to |
0e14050
to
9f13360
Compare
9f13360
to
fbf540f
Compare
@bryanwweber and @speth ... now that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ischoegl. This looks good to me.
newPhase
bynewSolution
in C++ examplesCloses #191