Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions for Intel compilers and compilation on conda #184

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Update instructions for Intel compilers and compilation on conda #184

merged 4 commits into from
Mar 28, 2022

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Mar 27, 2022 •
edited
Loading

  • Update information on Intel compilers
  • Update information on compilation in conda environment

Closes #170, closes #181

@ischoegl ischoegl force-pushed the compilation-updates-for-2.6 branch 2 times, most recently from 96abb21 to 78cefa4 Compare March 27, 2022 18:25
@ischoegl ischoegl changed the title Update instructions for Intel compilers Update instructions for Intel compilers and compilation on conda Mar 27, 2022
@ischoegl ischoegl force-pushed the compilation-updates-for-2.6 branch from 78cefa4 to 5ea4cd9 Compare March 27, 2022 18:41
@ischoegl ischoegl marked this pull request as ready for review March 27, 2022 18:41
@ischoegl
Copy link
Member Author

@speth and @bryanwweber ... this is ready for review. I set the destination to the testing branch, as some of the modifications will only work for 2.6.

@ischoegl ischoegl requested a review from a team March 27, 2022 18:43
@ischoegl ischoegl added the documentation-update An update is needed to the documentation label Mar 27, 2022
bryanwweber
bryanwweber requested changes Mar 27, 2022
View reviewed changes
Copy link
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes here. Thanks for taking this on!

pages/compiling/installation-reqs.rst Outdated Show resolved Hide resolved
pages/compiling/installation-reqs.rst Outdated Show resolved Hide resolved
pages/compiling/installation-reqs.rst Outdated Show resolved Hide resolved
pages/compiling/installation-reqs.rst Outdated Show resolved Hide resolved
pages/compiling/special-cases.rst Outdated Show resolved Hide resolved
speth
speth requested changes Mar 27, 2022
View reviewed changes
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions.

pages/compiling/dependencies.rst Outdated Show resolved Hide resolved
pages/compiling/dependencies.rst Outdated Show resolved Hide resolved
@ischoegl
Copy link
Member Author

@bryanwweber and @speth ... thank you for your suggestions! I adopted all, and also added more detailed instructions for conda on windows (specifically, how to set environment variables for MSVC).

@ischoegl ischoegl force-pushed the compilation-updates-for-2.6 branch from 4e3d565 to 9bc222f Compare March 28, 2022 03:39
@ischoegl ischoegl force-pushed the compilation-updates-for-2.6 branch from 9bc222f to c2d64e9 Compare March 28, 2022 03:44
@ischoegl ischoegl merged commit 775173e into testing Mar 28, 2022
@ischoegl ischoegl deleted the compilation-updates-for-2.6 branch March 28, 2022 12:37
This was referenced Mar 28, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanwweber bryanwweber bryanwweber approved these changes

@speth speth Awaiting requested review from speth

Assignees
No one assigned
Labels
documentation-update An update is needed to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ischoegl @speth @bryanwweber