Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-1778: Improve timing of Query calls #748

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

OrdiNeu
Copy link
Contributor

@OrdiNeu OrdiNeu commented Sep 19, 2024

Jira Link

DIG-1778

Description

This creates a new /v3/authorized/query/ endpoint in Katsu to drastically improve the performance of Query by combining all of its required information&filtering into one request. No changes to the output should be present, but the performance should see a ~2x speedup.

To test

There are unit tests in Katsu under lib/katsu/katsu_service/chord_metadata_service/mohpackets/tests/endpoints/test_donor.py but mostly the integration tests should catch most of this. No change to Query should be present, besides the speedup.

Other PRs

Katsu
Query

Copy link
Contributor

@SonQBChau SonQBChau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it works fine. But, it took me a while to manually override all the synthetic data for ingestion, so I recommend holding off on merging until we have the updated synthetic data.

@OrdiNeu OrdiNeu merged commit 56571d6 into develop Sep 27, 2024
2 checks passed
@OrdiNeu OrdiNeu deleted the other/offload-joins-to-katsu branch September 27, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants