Added bun functuality #4
Conversation
|
I fixed a issue in the bun version and also directly adressed the issue stated in pr #5 |
There was a problem hiding this comment.
I was able to get this working with my test application, but i had to make a couple of small adjustments to the package.json file for it run properly. Please see comments below, there is also a couple of small clean up things that i think needs to be done before the merge.
|
I will Look into it |
|
The dist/bun probably can be removed, cause bun does not need to get compiled. In your package do you publish just the dist folder as package or everything? |
|
I have found a better wider compatible option. It now uses Axios instead of node fetch wich should make it compatible with a wider range of runntimes |
|
Also it does not require a bigger package size and should work as normal |
There was a problem hiding this comment.
Changes look good, Axios has replaced node-fetch. I pushed a commit to change the type of the headers from AxiosRequestHeaders to RawAxiosRequestHeaders as some of the other API calls have other fields included in their headers and it was complaining about them.
I added bun functuality. You can (or you should be able to) use the package normaly. And if you use bun you need to set a /bun/src (I will further look into it to remove the src) to use the bun optimized version.