Remove old style kickstart generation. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if hosts_file_use_custom_inventory == True, skipping over all the hosts in the old-style kickstart generation takes a long time. In our environment, running ansible-playbook install.yml --tags=pxe shows the following timings: Wednesday 14 September 2016 10:10:12 +0300 (0:00:01.322) 0:02:16.558 *** =============================================================================== ansible-role-pxe_config : copy over kickstart file (old style) --------- 34.82s ansible-role-pxe_config : populate hosts file from template with PXE hosts -- 20.68s ansible-role-pxe_config : create pxe boot data json file --------------- 19.28s ansible-role-pxe_config : create_dhcp_configs -------------------------- 19.10s ansible-role-pxe_config : copy over kickstart file (new and faster style) --- 9.45s (top 5 only, all other tasks are below 2s.)
|
I'd like to first get the new and shiny custom-inventory.py in use in fgci-ansible's master branch and have us check on the other fgci sites how it looks before we change the default. |
|
I've put the question in the meeting minutes for the weekly Friday meeting. I can't check this for sites as I don't have access (nor would I like to have) to configure their install nodes. If there are no objections we're merging this on Friday to be included in the release. |
martbhell
added a commit
to fgci-org/fgci-ansible
that referenced
this pull request
Sep 23, 2016
mantti
pushed a commit
to mantti/fgci-tut
that referenced
this pull request
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if hosts_file_use_custom_inventory == True, skipping over all the
hosts in the old-style kickstart generation takes a long time. In our
environment, running
ansible-playbook install.yml --tags=pxe
shows the following timings:
Wednesday 14 September 2016 10:10:12 +0300 (0:00:01.322) 0:02:16.558 ***
ansible-role-pxe_config : copy over kickstart file (old style) --------- 34.82s
ansible-role-pxe_config : populate hosts file from template with PXE hosts -- 20.68s
ansible-role-pxe_config : create pxe boot data json file --------------- 19.28s
ansible-role-pxe_config : create_dhcp_configs -------------------------- 19.10s
ansible-role-pxe_config : copy over kickstart file (new and faster style) --- 9.45s
(top 5 only, all other tasks are below 2s.)